Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Move single cycle/diagram plotting code into new, public plotting function #52

Closed
nawtrey opened this issue Dec 8, 2021 · 1 comment
Labels
API API-related changes

Comments

@nawtrey
Copy link
Collaborator

nawtrey commented Dec 8, 2021

As discussed in 6. of this comment, the single-diagram/cycle cases of draw_cycles() and draw_diagrams() probably belong elsewhere, potentially in a separate, public function. It seems a little awkward to input a single diagram/cycle into plural-named functions anyways, although a general plotting function might want to handle this case.

This will have to be resolved after #47, and likely after #48.

@nawtrey nawtrey added API API-related changes and removed maintenance labels Aug 4, 2024
@nawtrey
Copy link
Collaborator Author

nawtrey commented Aug 10, 2024

I don't think this is necessary. I think it would be way more awkward to have multiple functions to handle 1 vs. 2+ diagrams. With the new KineticModel object, I think it will be easy to build methods for easy plotting of diagrams. I'll open a separate issue for that when the time comes, so closing this.

@nawtrey nawtrey closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API-related changes
Projects
None yet
Development

No branches or pull requests

1 participant