Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add unit tests for plotting helper functions #49

Open
nawtrey opened this issue Dec 8, 2021 · 2 comments
Open

TST: Add unit tests for plotting helper functions #49

nawtrey opened this issue Dec 8, 2021 · 2 comments
Labels
testing Testing/verification related improvements/bugs

Comments

@nawtrey
Copy link
Collaborator

nawtrey commented Dec 8, 2021

As mentioned in 4. of this comment, there are several plotting functions that could use unit tests in plotting.py. At the moment the plotting test doesn't properly "test" anything, they primarily flush the code paths to make sure there aren't any errors raised. But adding some unit tests would be a good start.

@nawtrey nawtrey added the testing Testing/verification related improvements/bugs label Dec 8, 2021
@nawtrey
Copy link
Collaborator Author

nawtrey commented Dec 8, 2021

I should note that once this issue is resolved, a new issue should be opened to address more rigorous testing of the public plotting functions.

@nawtrey nawtrey mentioned this issue Dec 8, 2021
5 tasks
@nawtrey
Copy link
Collaborator Author

nawtrey commented Apr 8, 2022

_plot_panel(cbt=True) needs to be tested for more complex graphs like the 8-state model in the kda-examples repo. It currently "works", but we don't have any tests that actually check if the correct nodes are being colored in the figure generated by plotting._plot_panel(). It's never easy to pull data out of matplotlib figures, but it would be nice to retrieve the node indices and their respective colors directly from the subplots and compare them to the expected values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing/verification related improvements/bugs
Projects
None yet
Development

No branches or pull requests

1 participant