-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obscure TypeError when supplying unused kwargs to Gsolv
#273
Comments
Yes, make sense. I think when I wrote this a log time ago I was only slowly learning how to do class inheritance and using Also, I don't think that the "restarting" code is particularly well tested. It seemed like a good idea at the time to make it convenient to restart, but I don't think I was a strong believer in tests then :-(. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional
kwargs
get passed to thesuper()
class, which isJournalled
.Journalled
then passes them on toobject
, from which it inherits. This results in a slightly obscure error:It may be better to check for any extra keyword arguments in
Journalled.__init__()
, replacing thesuper().__init__()
call.The text was updated successfully, but these errors were encountered: