Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace bundled tempdir with pytest tmpdir fixture #194

Open
orbeckst opened this issue Sep 10, 2021 · 2 comments
Open

replace bundled tempdir with pytest tmpdir fixture #194

orbeckst opened this issue Sep 10, 2021 · 2 comments
Labels
refactoring testing

Comments

@orbeckst
Copy link
Member

Many tests still use tests/tempdir.py. Remove and replace the use with the pytest tmpdir/tmpfile fixture.
@orbeckst orbeckst mentioned this issue Sep 20, 2021
Merged
@orbeckst
Copy link
Member Author

Actually, tmpdir is kind of deprecated, use tmp_path

@cadeduckworth
Copy link
Contributor

Working list:
for removing setup & teardown

  • test_Gsolv
  • test_dihedral
  • test_ensemble
  • test_equilibration_script
  • test_fep_script
  • test_solv_shell

Working list:
for changing tmpdir to tmp_path

  • test_analysis
  • test_analysis_alchemlyb
  • test_solvation

@orbeckst orbeckst mentioned this issue Feb 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orbeckst @cadeduckworth