-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no backwards compatibility for the "watermodel" option of configuration file #140
Labels
Comments
How should this work? Should we just use watermodel as equivalent to solventmodel? |
Or would it be better to fail when watermodel is encountered? |
Both options are fine for me. Probably use watermodel as equivalent to solventmodel is better, as in reality solventmodel is a synonym of watermodel, but with broader applicability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The "watermodel" option of the configuration file that was present originally in MDPOW was replaced by the more general "solventmodel". Currently, when the "watermodel" option is present in the configuration file, MDPOW ignores it silently and uses the default water model, which is not the desired one.
The backwards compatibility should be ensured for this option.
The text was updated successfully, but these errors were encountered: