-
-
Notifications
You must be signed in to change notification settings - Fork 309
Consider adding relevant network object to RpcArgs #398
Comments
Slightly off-topic: How big is a NetworkObject in byte size? |
Sure! An example: I have a network object A supporting an RPC This separates the responsibility of handling the RPC from the network object itself, which is especially useful if it has many RPCs, keeps concerns separated, and allows minimizing injected dependencies in that class as well as for the network object (in case you use dependency injection, which I do). |
Version Number and Operating System(s):
Windows 10, Forge Network Alloy at da8e129 (develop).
Expected behavior:
Easy way to access relevant network object RPC was invoked on from
RpcArgs
(orRpcArgs.RPCInfo
).This is a fairly minor thing, since RPC handlers exist in the network object to begin with, grabbing
networkObject
inside the behavior object is fairly easy to do to work around this. The reason I'm asking is because during refactoring one may create different classes to handle specific RPCs, which then need to be passed not only theRpcArgs
, but also the relevantNetworkObject
. This results in a so-called data clump.Actual behavior:
No way to easily access relevant network object RPC was invoked on from
RpcArgs
.Steps to reproduce:
Create an RPC and a handler for it and observe that you cannot directly access the relevant network object from it.
The text was updated successfully, but these errors were encountered: