Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK : run check on excessive login/logouts #120

Open
orubel opened this issue Jun 14, 2024 · 2 comments
Open

TASK : run check on excessive login/logouts #120

orubel opened this issue Jun 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@orubel
Copy link
Collaborator

orubel commented Jun 14, 2024

people may attempt login/logout to attempt to bypass functionality

This is an immediate flag for attempted hacking.

If we add a ratelimit to login attempts this will help reduce attempts.

for example:

  • 3+ login/logouts in 5 minute earns a temporary lock; first time = 30 mnnutes
  • locktime is then calculated as currentlocktime X badSessionOccurences

so ...

  • 1st time = 30 minutes (30 x 1) (default for 'lockTime' on all accts)
  • 2nd time = 1 HR (30 x 2) (change numberofoccurences)
  • 3rd time = 3 hrs (60 x 3) (change locktime for acct & badSessionOccurences)
  • 4th time = 12 hrs (180x4) (change locktime for acct & badSessionOccurences)
  • etc

We store 'lockTime' & 'numberofoccurencesas with User domain
We can add ROLES that bypass the check(ie ROLE_TEST, ROLE_ADMIN)

@orubel orubel added the bug Something isn't working label Jun 14, 2024
@orubel orubel self-assigned this Jun 14, 2024
@orubel
Copy link
Collaborator Author

orubel commented Jun 14, 2024

Also we have to

  • change User domains/services for these variables
  • add getters/setters for the variables
  • add endpoints to User controller
  • change IO state for User and limit who can access these endpoints

@orubel
Copy link
Collaborator Author

orubel commented Jun 21, 2024

Been thinking about this more and this actually would lend itself WELL as form of 'dynamic rate limiting' where we scale down the rate for requests if they login/logout several times

  • scale down the amount of requests they can make
  • scale down the time in which they can make these requests.
  • scale up lockout time.

@orubel orubel added enhancement New feature or request and removed bug Something isn't working labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant