Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heart + Slider fix? #272

Open
Cryptises opened this issue Oct 31, 2022 · 7 comments
Open

heart + Slider fix? #272

Cryptises opened this issue Oct 31, 2022 · 7 comments
Assignees

Comments

@Cryptises
Copy link

Is there a way to remove the too early hit miss, some of the time, whenever a slider shows up with notes under it, almost every time, if there's a heart, it's 85% of the time at the beginning of the slider. and if you hit the heart just a tiny bit earlier than the slider, it'll cause the next note to miss. Removing early hit miss will fix this, but the other solution is simply making the heart a note,

Another unrelated thing, I know Osu's system isn't exactly flexible with all this, but with hearts, they shouldn't actually be a hittable thing at all, you just colide with it and you simply get the health, is there a way to add that to osu? If it is impossible then I guess we can just deal with it, but it would be a nice QoL thing to have

@LumpBloom7 LumpBloom7 self-assigned this Oct 31, 2022
@LumpBloom7 LumpBloom7 added area:objects proposal A suggestion for a potential addition and removed proposal A suggestion for a potential addition labels Oct 31, 2022
@LumpBloom7
Copy link
Collaborator

LumpBloom7 commented Oct 31, 2022

The heart is supposed to act like a regular note if an attempt to hit the note is made, so that it can be "caught" while the sprite is on the other lane. (dealing with a slider for example)

A hit directed at the heart would not transfer to another note, if the heart isn't collected yet. However, the heart checks for collision at exactly time 0, so any hit attempts directed at the heart past that time will carry to the next note, because the heart is collected already. This can occur if you are a bit late on hitting the slider above, leaving the sprite to collect the heart below. If you feel that this is not the case, please record some gameplay and we'll have a look at it.

To Team: We should prolly improve the feel of this at some point. (Further reading: https://discord.com/channels/741467017923788900/825687815734951956/831832065095893042)

@Cryptises
Copy link
Author

Yeah, I'll see if I can find a replay of it

@Cryptises
Copy link
Author

Cryptises commented Nov 6, 2022

I got one, skip to 2 minutes if you don't want to sit through the whole song (Forgive the lag spikes, and uh my terrible blunders)
As you can see I retried plenty of times to try to get the video just perfect for it lol

Another note, only OBS had those giant lag spikes, Osu only suffered minor hiccups (drops to maybe 100-200 fps)
https://mega.nz/file/qRFhhZJK
Decryption Key: G6h7_O40qxLtOXsndpXzVXGL324kET9yYe9OjjbznqU
Also, I am sorry for the late reply.

@LumpBloom7
Copy link
Collaborator

LumpBloom7 commented Nov 6, 2022

Based on the hit timings, it does indeed seem like you hit both of the notes slightly late, which by that point meant that the heart has already been collected by the time you've hit it.

This is still a valid issue though since it's not fun to be punished for being slightly off.

(Maybe the heart collection should be left to after the hitwindow?)

@Cryptises
Copy link
Author

Cryptises commented Nov 6, 2022

If there's a way to make slider notes (even hearts) always be hittable even not on slider, that could fix this issue, But I am not sure how far Osu's limitations go, so whatever you think would work would probably be best, If the issue is still there, I'll just point it out again, So take your time working out different theories
Edit: Although after reading what you said again, it kinda seems like it might be better to just make it a note, and if in the future a better solution can be implemented then ofc, implement it

@LumpBloom7
Copy link
Collaborator

Don't worry about it, I'll be trying something out. Osu limitations don't apply here.

The heart is already acts as a note + extra check, it is the extra check that is being too eager, and this value can always be tuned.

@Cryptises
Copy link
Author

Gotcha, I look forward to seeing the improvements you can make :3 and hopefully it will permanently fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants