Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the locking button to a floating action button (FAB) #33

Open
GrazianoCapelli opened this issue Oct 1, 2024 · 2 comments
Open
Labels
enhancement New feature or request like to implement We want to add the feature in the next releases

Comments

@GrazianoCapelli
Copy link
Member

GrazianoCapelli commented Oct 1, 2024

At this time the lock button is on the top-left corner, near the 3 yellow angle values. Unfortunately in this position the button (that is the most used one) is not comfortable for the user.
We would like to move the lock button on a FAB (floating action button) located in the bottom-right corner, the standard position of the Android FABs.

Here a mockup of the main activity:

ClinometerFAB

The button should work exactly like the existing one, using setOnTouchListener.
In the future we might use the angles label on top-left corner to copy the values to the clipboard (issue #5).

PS: the FAB it is NOT 100% standard: the implementation is a bit tricky because the activity doesn't rotate when the user rotate the phone; We rotate only part of the interface, without re-create the activity.

@GrazianoCapelli GrazianoCapelli added enhancement New feature or request like to implement We want to add the feature in the next releases labels Oct 1, 2024
@dhfherna
Copy link

dhfherna commented Oct 1, 2024

Hi, I would like to work in this issue!

@GrazianoCapelli
Copy link
Member Author

Hi @dhfherna,
I want to point out that the FAB it is NOT 100% standard: the implementation is a bit tricky because the activity doesn't rotate when the user rotate the phone; We rotate only part of the interface, without re-create the activity.
I added the note to the header comment too.

If you are comfortable with this, give me the OK and I'll be glad to assign the issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request like to implement We want to add the feature in the next releases
Projects
None yet
Development

No branches or pull requests

2 participants