-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghost clients #113
Labels
Comments
Hi, have you found a solution? |
I don't understand this issue and how all of that is possible, but I welcome a reproducible example. |
It's been so long i'm not sure if I remember clearly, but
Hope they help. |
Open a new issue if you encounter anything like that (on the latest version). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, first I want to thank you for this library. It's awesome! saving a lot of time :)
There are 2 issues I'm having at the moment.
I'm using the library in Express, where I create one or more instances(already logged in) on HTTP requests, and after finishing with clients, close them accordingly by client.close().
For example,
router.get('/', async (req, res) => {
var key = getApiKeyFromDB()
var client1 = new Client({...});
//Ater done with client1, close
await client1.close();
...
var client2 = new Client({...});
...
await client2.close();
});
I haven't REALLY tested the problems and how they occur yet (can't find stable error patterns)
But, for issue 1, executing multiple client methods like in a loop, Express crashes throwing bunch of V8 errors, and restart.
For issue 2, in most cases, I think I properly close all the clients, but there are cases where there are yet unknown clients hanging around in the server, or unintentionally crashing into a same client from other processes like node-scheduler.
The memory issue I currently have no idea with it.
But for ghost clients, I wonder if there is a way to check for clients (like client list?) so another process can reuse or close.
The text was updated successfully, but these errors were encountered: