Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Punishments can't be removed by lowest staff's ranks + revoke OWN punishment permissions #965

Open
Cr4zyGeek opened this issue Feb 20, 2022 · 3 comments

Comments

@Cr4zyGeek
Copy link

If an ADMINISTRATOR punished a player, then a MODERATOR can't revoke this punishment,
If a MODERATOR punished a player, then an HELPER can't revoke this punishment but an ADMINISTRATOR could do it

+ create permissions bm.command.[unbanip/unwarn/...].own for each punishment type

@confuser
Copy link
Member

So the first request isn't possible. Bukkit's permission system does not allow for checking permissions of offline players.

The second is, I can add .own permissions for unbanning ip, dwarn etc

@Cr4zyGeek
Copy link
Author

Cr4zyGeek commented Feb 20, 2022

For the 1st, you could create a system of personalized permissions like bm.staff.<rank>
=> bm.staff.administrator / bm.staff.moderator / bm.staff.helper, then when someone is punished, the <rank> is stored in the database

In config you :
+ add the possibility to enable/disable the feature
+ create a category to define the rank order like :

staff-order-revoke: true

staff-order:
  - administrator
  - moderator
  - helper

and then if this feature is enabled, when someone wants to revoke someone's punishment, you check in the database the rank of the punisher compared to the actual bm.staff.<rank> of the player who wants to revoke the punishment

+ then it could be interesting to add the option to disable the possibility to staff members to revoke punishment applied by others staff members with the same rank :
like MODERATOR can't unban a player banned by an other MODERATOR

For the 2nd, it's exactly what i meant ^^

@Romvnly-Gaming
Copy link

How about relying on Vault to allow permission plugins that support checking offline players?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants