Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completions should be case insensitive #897

Open
piotrskibapl opened this issue Aug 17, 2020 · 2 comments
Open

Tab completions should be case insensitive #897

piotrskibapl opened this issue Aug 17, 2020 · 2 comments
Labels

Comments

@piotrskibapl
Copy link

Issue report

Tell us about your environment

  • Server Software: git-Paper-384

  • Server Version: 1.15.2

  • BanManager Version: 7.2.2

  • Online/Offline mode: offline

  • Bungeecoord online/offline mode (if applicable): offline

BanManager config.yml:

not relevant

Describe your issue:

Currently, all BanManager commands have case sensitive tab suggestions. That is sometimes annoying, especially when you want to punish a player fast. Almost all other commands (including these from spigot itself) have case insensitive suggestions.

@confuser
Copy link
Member

The issue here is offline mode support as names are case sensitive, e.g. confuser and Confuser are two different players under Bukkit/Spigot. How would you suggest handling this with auto complete?

@piotrskibapl
Copy link
Author

@confuser in this particular case, when I start typing "con" and press tab, I'd like to see both "confuser" and "Confuser" in the suggestions so I could switch between them easily (and that's the behavior of vanilla Minecraft I guess).

I've looked into the code and it seems to me that the current implementation of tab completions won't allow us to apply these changes easily. I can also see that disabling the offlineAutoComplete option in the config solves the issue for online players, so I'll stick to that for now. I'll let you know if I found any other solution next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants