Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BNFC tarball ships Lex.hs and Par.hs #467

Closed
andreasabel opened this issue Nov 3, 2023 · 0 comments · Fixed by #466
Closed

BNFC tarball ships Lex.hs and Par.hs #467

andreasabel opened this issue Nov 3, 2023 · 0 comments · Fixed by #466
Assignees
@andreasabel
Labels
bug build Building BNFC installation
Milestone
2.9.5.1

Comments

@andreasabel
Copy link
Member

andreasabel commented Nov 3, 2023 •
edited
Loading

This affects all releases of BNFC 2.9 and most of 2.8.
Not affected: 2.8.1, 2.8.3.1

It is not clear though whether this makes cabal skip the alex and happy steps. So it could be a cosmetic issue.
I had some problem with 2.8.3 (fixed in 2.8.3.1), but that shipped several copies of Lex.hs:

BNFC-2.8.3/dist/build/unit-tests/unit-tests-tmp/LexBNF.hs
BNFC-2.8.3/dist/build/bnfc/bnfc-tmp/LexBNF.hs
BNFC-2.8.3/src/LexBNF.hs

Today I witnessed a build failure of BNFC with an old alex (using GHC 9.4 with alex 3.2.5). Maybe this can be fixed by requiring a new alex and happy in the build-tool-depends section that create output valid for all GHCs we support (8 and 9 so far).
Reproducer would be:

  • install alex-3.2.5
  • install recent GHC, e.g. 9.4.7
  • cabal install BNFC-2.9.5
@andreasabel andreasabel added this to the 2.9.5.1 milestone Nov 3, 2023
@andreasabel andreasabel self-assigned this Nov 3, 2023
@andreasabel andreasabel linked a pull request Nov 3, 2023 that will close this issue
Don't add Lex/Par.hs to sdist tarball #466
Merged
@andreasabel andreasabel changed the title BNFC tarball ships Lex.hs and Par.hs which could lead to build failure BNFC tarball ships Lex.hs and Par.hs Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
bug build Building BNFC installation
Projects
None yet
Milestone
2.9.5.1
Development

Successfully merging a pull request may close this issue.

Don't add Lex/Par.hs to sdist tarball BNFC/bnfc
1 participant
@andreasabel