Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Reject input with invisible/zero-width character #1544

Open
JoeyC-Dev opened this issue Apr 26, 2024 · 0 comments
Open

[Feature request] Reject input with invisible/zero-width character #1544

JoeyC-Dev opened this issue Apr 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JoeyC-Dev
Copy link

JoeyC-Dev commented Apr 26, 2024

Describe the solution you'd like
For example, there is a yaml file as below, and it should be rejected:

apiVersion: secrets-store.csi.x-k8s.io/v1
kind: SecretProviderClass
metadata:
  name: azure-kvname-wi 
spec:
  provider: azure
  parameters:
    usePodIdentity: "false"
    clientID: 00000000-0000-0000-0000-000000000000​
    keyvaultName: ${KEYVAULT_NAME}
    cloudName: ""
    objects:  |
      array:
        - |
          objectName: secret1 
          objectType: secret 
          objectVersion: ""      
    tenantId: "${IDENTITY_TENANT}" 

image

When there is a root cause like this happening to an incident, it is a disaster to find it out. 
(The reason I submitted this feature request is because it happened recently. We just had no where out at the time until we find the "space-like" thing when manually opened the yaml with VSC. The issue kept for 3 days.)

Anything else you would like to add:
N/A

Environment:

  • Secrets Store CSI Driver version: (use the image tag): v1.4.2
  • Azure Key Vault provider version: (use the image tag): v1.5.1
  • Kubernetes version: (use kubectl version): 1.28.3
  • Cluster type: (e.g. AKS, aks-engine, etc): AKS
@JoeyC-Dev JoeyC-Dev added the enhancement New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant