Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally block patches until composition deletion #241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jveski
Copy link
Collaborator

@jveski jveski commented Nov 4, 2024

Resolves #232

There's a common use case in which Eno deploys a controller which then creates some resources that aren't managed by Eno. So if Eno removes the controller, those resources will never be cleaned up.

An easy way to handle this: allow patches to be deferred until the composition is deleted. Deletion patches can then be defined to remove any known state that might be left behind by the controller.

@chihshenghuang
Copy link
Contributor

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch hook for composition deletion
2 participants