Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: RoleAssignment and SqlRoleAssignment don't consider the ARMID of their owner when generating a unique ID #4079

Open
matthchr opened this issue Jun 11, 2024 · 1 comment
Assignees
Labels
breaking A change which likely be breaking bug 🪲 Something isn't working
Milestone

Comments

@matthchr
Copy link
Member

Version of Azure Service Operator
ASOv2

Describe the bug
The RoleAssignment and SqlRoleAssignment resources don't account for the fact that their owner can be an ARM ID (empty group + kind + name). When the owner is from an ARM ID, they don't include that in their unique UUID generation, which means that two different clusters with RoleAssignments with the same namespace/name but different ARMID owners will have the same UUID generated and collide.

Expected behavior
The owner is considered in UUID generation.

Additional context
Fixing this may be breaking, though we can consider using #3935 to allow users to opt-back into the old behavior if we wanted.

@matthchr matthchr added the breaking A change which likely be breaking label Jun 11, 2024
@matthchr matthchr added this to the v2.9.0 milestone Jun 11, 2024
@matthchr matthchr self-assigned this Jun 11, 2024
@matthchr
Copy link
Member Author

There's also a (less critical) bug around group/kind ordering in the uniqueness string we could fix as part of this... not sure if it's worth it though as it will likely impact more users.

@matthchr matthchr added bug 🪲 Something isn't working and removed needs-triage 🔍 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change which likely be breaking bug 🪲 Something isn't working
Projects
Development

No branches or pull requests

1 participant