chore(playwrighttesting): use playwright OSS types #32319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sid200026
requested review from
bterlson,
a team,
puagarwa and
ShreyaAnand
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…per APIView review
|
Also renamed |
mxschmitt
approved these changes
Dec 20, 2024
sdk/playwrighttesting/microsoft-playwright-testing/test/utils/clInfoProvider.spec.ts
Outdated
Show resolved
Hide resolved
…clInfoProvider.spec.ts Co-authored-by: Max Schmitt <[email protected]>
This reverts commit f42202f.
This reverts commit 8ab8306.
|
This PR also removes the below constants from the public variable |
kashish2508
approved these changes
Dec 23, 2024
puagarwa
approved these changes
Dec 27, 2024
…into users/ssingharoy/use-playwright-oss-types
|
/azp run js - playwrighttesting |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run js - playwrighttesting |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maorleger
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/microsoft-playwright-testing
Issues associated with this PR
Type changes by playwright OSS will impact @azure/microsoft-playwright-testing SDK if relevant types are hardcoded.
Also fixes #32394
Describe the problem that is addressed by this PR
Instead of having playwright OSS types hardcoded in the package, we will use the types provided by the playwright OSS package itself (Playwright OSS is added as a peer dependency).
This also changes peer dependency version of playwright OSS to v1.47, which is the minimum supported version of playwright OSS for this SDK.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists