-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[engsys] upgrade Eslint to v9 #29750
Labels
Comments
github-actions
bot
added
the
needs-triage
This is a new issue that needs to be triaged to the appropriate team.
label
May 17, 2024
jeremymeng
added
EngSys
This issue is impacting the engineering system.
eslint plugin
labels
May 17, 2024
github-actions
bot
removed
the
needs-triage
This is a new issue that needs to be triaged to the appropriate team.
label
May 17, 2024
jeremymeng
added a commit
that referenced
this issue
May 21, 2024
ESLint v9 drops support for legacy .eslintrc style configuration files. To move to v9 we need to migrate to the new Flat Config files. This PR adds support for Flat Config file and migrate cosmos and identity-broker packages to use the flat config. Legacy config files are still supported. Some eslint plugins that we use don't support flat config yet so they are disabled. Related issue: #29750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One of the notable breaking changes is the moving to Flat Config and dropping support for legacy config files. To upgrade to v9, we need to
dev-tool admin list packages
to apply the transformation for all packages in one go.--ext
command line option--ext
option for exampleIssues
some plugins we are using today doesn't fully support ESLint v9 yet. They were enabled with the help of @eslint/compat
VSCode eslint plugin's support for v9 hasn't landed yet Enable Flat Config by default microsoft/vscode-eslint#1644
The text was updated successfully, but these errors were encountered: