Removing blocking from FileAsyncApiTests file

[gunjansingh-msft]

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

• The pull request does not introduce [breaking changes]
• CHANGELOG is updated for new features, bug fixes or other significant changes.
• I have read the contribution guidelines.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

[azure-sdk]

API change check

API changes are not detected in this pull request.

[ibrandes]

Looking good so far! Make sure to re-record the tests you added the missing .verifyComplete() step to so we can get a good idea of what CI looks like.

[ibrandes]

typically, we never want to use * imports. intellij likes to add these automatically sometimes even if you have "Use single class import" checked, but you can (mostly) ensure it never does this by going to Settings > Editor > Code Style > Java, and changing "Class count to use import with *" and "Names count to use static import with *" to 1000. While you're there, you can also make sure "Use single class import" is checked.

[ibrandes]

right now, this test is failing because .doOnNext() emits a mono, and .expectComplete() assumes nothing else is emitted. also, nesting the PollerFlux in a mono is a little awkward.

you can change it to

Flux<AsyncPollResponse<ShareFileCopyInfo, Void>> poller = optionsMono.flatMapMany(
            options -> setPlaybackPollerFluxPollInterval(primaryFileAsyncClient.beginCopy(sourceURL, options, null)));

        StepVerifier.create(createFileMono.thenMany(poller))
            .assertNext(it -> assertNotNull(it.getValue().getCopyId()))
            .expectComplete()
            .verify(Duration.ofMinutes(1));

[ibrandes]

This fails because you are comparing e.getErrorCode() (which returns a ShareErrorCode object) to a string. You can change e.getErrorCode() to e.getErrorCode().toString() and it should pass

[ibrandes]

We can also make use of returning just the PollerFlux here instead of doing anything extra to it:

@Test
    public void startCopyWithOptionsLease() {
        String sourceURL = primaryFileAsyncClient.getFileUrl();
        Mono<String> leaseIdMono
            = primaryFileAsyncClient.create(1024).then(createLeaseClient(primaryFileAsyncClient).acquireLease());

        StepVerifier.create(leaseIdMono.flatMapMany(leaseId -> {
            ShareRequestConditions conditions = new ShareRequestConditions().setLeaseId(leaseId);
            ShareFileCopyOptions options = new ShareFileCopyOptions().setDestinationRequestConditions(conditions);
            return setPlaybackPollerFluxPollInterval(primaryFileAsyncClient.beginCopy(sourceURL, options, null));
        })).assertNext(it -> assertNotNull(it.getValue().getCopyId())).expectComplete().verify(Duration.ofMinutes(1));
    }

[ibrandes]

This is not checking if the copy actually throws the error, as the error is thrown manually on line 1097. We want to change this to:

StepVerifier
            .create(createFileMono.thenMany(
                setPlaybackPollerFluxPollInterval(primaryFileAsyncClient.beginCopy(sourceURL, options, null))))
            .verifyErrorSatisfies(r -> {
                ShareStorageException e = assertInstanceOf(ShareStorageException.class, r);
                assertEquals("LeaseNotPresentWithFileOperation", e.getErrorCode().getValue());
            });

This ensures that the copy actually throws the error.

[ibrandes]

We don't want to manually throw an error, as that doesn't check if the error actually occurs when making the call. Check my previous comment to see how to change this.

[ibrandes]

Although this works, I think it is important to follow the normal structure of StepVerifier we've been using for other tests unless absolutely necessary.

[ibrandes]

There are several redundant statements here - you can remove the then()'s and change the last .then( to .thenMany(

StepVerifier.create(primaryFileAsyncClient.createWithResponse(1024, null, null, null, null)
            .then(primaryFileAsyncClient.uploadFromFile(uploadFile))
            .then(createLeaseClient(primaryFileAsyncClient).acquireLease())
            .thenMany(primaryFileAsyncClient
                .listRanges(null, new ShareRequestConditions().setLeaseId(testResourceNamer.randomUuid()))))
            .verifyError(ShareStorageException.class);

[gunjansingh-msft]

/check-enforcer override

[gunjansingh-msft]

/azp run java - storage - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).