Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Maps] Traffic Incident 2025-04-01 #31578

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[Azure Maps] Traffic Incident 2025-04-01 #31578

wants to merge 14 commits into from
+362 −1

Conversation

miaxzhitong
Copy link
Member

@miaxzhitong miaxzhitong commented Nov 16, 2024 •
edited
Loading

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

fix #31596

@miaxzhitong
Copy files from preview/1.0
ea122d9 
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
@miaxzhitong
Update version to stable/2025-04-01
7b3d0d5 
Updated the API version from preview/1.0 to stable/2025-04-01.
@miaxzhitong
Added tag for 2025-04-01 in readme file
cc062ca
@miaxzhitong
add traffic incident
a8a1779
@miaxzhitong miaxzhitong requested a review from a team as a code owner November 16, 2024 01:03
@miaxzhitong miaxzhitong requested review from vicancy and mikekistler and removed request for a team November 16, 2024 01:03
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 16, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ Your PR requires an API stewardship board review as it introduces a new API version (label: new-api-version). Schedule the review by following aka.ms/azsdk/onboarding/restapischedule.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 16, 2024 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@azure-sdk azure-sdk mentioned this pull request Nov 18, 2024
Open
@miaxzhitong miaxzhitong force-pushed the release-traffic-azuremaps-stable/2025-04-01 branch from 5c50b3c to 86d4a16 Compare November 19, 2024 06:11
@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Nov 19, 2024
@miaxzhitong miaxzhitong force-pushed the release-traffic-azuremaps-stable/2025-04-01 branch from 86d4a16 to ad4e15d Compare November 19, 2024 06:20
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicancy vicancy Awaiting requested review from vicancy vicancy is a code owner automatically assigned from Azure/api-stewardship-board

@mikekistler mikekistler Awaiting requested review from mikekistler mikekistler is a code owner automatically assigned from Azure/api-stewardship-board

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
data-plane Maps new-api-version PipelineBotTrigger SuppressionReviewRequired
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Azure Maps - Azure Maps] API Review
2 participants
@miaxzhitong @AzureRestAPISpecReview