You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #31536 for details. Note that the location property is defined multiple times with this same description, but only here it is listed as an enum. @shenglol suggests it's safer to remove the enum anyway, since that way new values can be added over time.
Here are other examples of "location" in the Microsoft.AzureActiveDirectory RP where it's simply a string:
"description": "The location in which the resource is hosted and data resides. Can be one of 'United States', 'Europe', 'Asia Pacific', or 'Australia' (preview). Refer to [this documentation](https://aka.ms/B2CDataResidency) for more information."
"description": "The location in which the resource is hosted and data resides. Can be one of 'United States', 'Europe', 'Asia Pacific', or 'Australia'. Refer to [this documentation](https://aka.ms/B2CDataResidency) for more information.",
"description": "The location in which the resource is hosted and data resides. Can be one of 'United States', 'Europe', 'Asia Pacific', or 'Australia'. Refer to [this documentation](https://aka.ms/B2CDataResidency) for more information."
❌ This is the public specs repo main branch which is not intended for iterative development. You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers. If this is what you intend, add PublishToCustomers label to your PR. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram
"description": "The location in which the resource is hosted and data resides. Can be one of 'United States', 'Europe', 'Asia Pacific', or 'Australia'. Refer to [this documentation](https://aka.ms/ciam-data-location) for more information.",
In this care are the descriptions of the location properties still acurate?
Refers to: specification/cpim/resource-manager/Microsoft.AzureActiveDirectory/preview/2023-05-17-preview/externalIdentities.json:1715 in 361d3d3. [](commit_id = 361d3d3, deletion_comment = False)
Yes this statement is still true for CIAM/External Id.
"description": "The location in which the resource is hosted and data resides. Can be one of 'United States', 'Europe', 'Asia Pacific', or 'Australia'. Refer to this documentation for more information.",
ARMReviewARMSignedOff<valid label in PR review process>add this label when ARM approve updates after reviewReadyForApiTest<valid label in PR review process>add this label when swagger and service APIs are ready for testresource-manager
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
razvanbadea-msft
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
Fixes #31536
See #31536 for details. Note that the location property is defined multiple times with this same description, but only here it is listed as an enum. @shenglol suggests it's safer to remove the enum anyway, since that way new values can be added over time.
Here are other examples of "location" in the Microsoft.AzureActiveDirectory RP where it's simply a string:
azure-rest-api-specs/specification/cpim/resource-manager/Microsoft.AzureActiveDirectory/preview/2019-01-01-preview/cpimTenant.json
Line 791 in 6d1ddf2
azure-rest-api-specs/specification/cpim/resource-manager/Microsoft.AzureActiveDirectory/preview/2019-01-01-preview/cpimTenant.json
Line 833 in 6d1ddf2
azure-rest-api-specs/specification/cpim/resource-manager/Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json
Line 955 in 6d1ddf2
azure-rest-api-specs/specification/cpim/resource-manager/Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json
Line 1000 in 6d1ddf2