Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to remove retired REST API specs is marked BreakingChangeReviewRequired #31445

Open
mikekistler opened this issue Nov 6, 2024 · 2 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikekistler
Copy link
Member

REST API specs PR 19679 is removing retired versions of REST API definitions from the repo and has been flagged as "BreakingChangeReviewRequired".

We created a label "Versioning-Approved-Retired" (Issue #30652) to use on PRs that remove retired API definitions from the repo, on the assumption that these would be flagged as "VersioningReviewRequired".

So either the above PR should have been flagged as "VersioningReviewRequired" or we need to add support for a "BreakingChange-Approved-Retired" label.

cc: @JeffreyRichter

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 6, 2024
@JeffreyRichter
Copy link
Member

Yes, I agree. I think it would be better if the tool added the VersioningReviewRequired label since deleting swaggers is NOT creating a new version of anything but changing existing version(s).
If, for some reason, this is too difficult to fix we could live with BreakingChangeReviewRequired and then apply a new BreakingChange-Approved-Retired label but this is not preferred.

@mikeharder mikeharder self-assigned this Nov 6, 2024
@mikeharder mikeharder transferred this issue from Azure/azure-sdk-tools Nov 6, 2024
@mikeharder
Copy link
Member

After the BreakingChanges check is migrated to our new platform, this type of change should be very easy to make. I will need to investigate the cost of changing this in the existing platform.

@mikeharder mikeharder moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Nov 6, 2024
@maririos maririos added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: No status
Development

No branches or pull requests

4 participants