Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new): Added Azure.Cosmos.DisableLocalAuth #2862

Conversation

BenjaminEngeset
Copy link
Contributor

PR Summary

Fixes #2846

Added Azure.Cosmos.DisableLocalAuth.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BenjaminEngeset BenjaminEngeset requested a review from a team as a code owner May 9, 2024 10:52
@BenjaminEngeset
Copy link
Contributor Author

BenjaminEngeset commented May 9, 2024

Ready for review @BernieWhite.

@BenjaminEngeset
Copy link
Contributor Author

Should be good now @BernieWhite after update.

@BenjaminEngeset
Copy link
Contributor Author

@BernieWhite I had some mess included from another branch, should be cleaned up now. Sorry for the mess.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @BenjaminEngeset. Just a few suggested changes below to round this out.

src/PSRule.Rules.Azure/rules/Azure.Cosmos.Rule.ps1 Outdated Show resolved Hide resolved
docs/en/rules/Azure.Cosmos.DisableLocalAuth.md Outdated Show resolved Hide resolved
@BenjaminEngeset
Copy link
Contributor Author

Great @BernieWhite. Adjusted accordingly to the suggestions now.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminEngeset. All good to merge.

@BernieWhite BernieWhite merged commit 40ac4fe into Azure:main May 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RULE] Cosmos DB No SQL API should disable local auth
2 participants