Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rule for API Management to use a SKU that supports AZ and multi-region deployments #2787

Open
jtracey93 opened this issue Mar 30, 2024 · 2 comments
Labels
pillar: reliability Aligned to the Reliability pillar. rule: api-management Rules for API Management
Milestone

Comments

@jtracey93
Copy link
Contributor

Existing rule

No response

Description of the issue

The following rules are being skipped in the AVM tests for no apparent reason for this resource, can you please advise:

Error messages

No response

Reproduction

Example AVM Workflows that have ran this for this resource can be seen here:

Version of PSRule

2.9.0

Version of PSRule for Azure

v1.35.0-B0116

Additional context

No response

@BernieWhite
Copy link
Collaborator

BernieWhite commented Apr 1, 2024

@jtracey93 Multi-region and availability zones only apply to premium SKU it's not supported on any other SKU, so these rules are not run if the resource uses a non-premium SKU. From my understanding e2e tests use the parameter default SKU of Developer.

We could add a rule to suggest that any APIM deployment should use the premium SKU, but it's likely this would not be ideal in a number of customer cases, so we have not so far. Although realistically it's the only option for AZ support currently, although Standard V2 I believe will drop with this at some point.

https://learn.microsoft.com/en-gb/azure/api-management/v2-service-tiers-overview#preview-limitations

@BernieWhite BernieWhite added waiting-feedback An issue or PR that needs author feedback. and removed Needs: Triage 🔍 labels Apr 1, 2024
@jtracey93
Copy link
Contributor Author

Agreed. I think the premium being the only way to get AZ support that is the WAF guidance means we should add a rule for it. It can always be suppressed.

@BernieWhite BernieWhite added rule: api-management Rules for API Management pillar: reliability Aligned to the Reliability pillar. and removed bug Something isn't working waiting-feedback An issue or PR that needs author feedback. labels Apr 1, 2024
@BernieWhite BernieWhite changed the title [BUG] APIM rules are being ignored/not ran in AVM tests Add a rule for API Management to use a SKU that supports AZ and multi-region deployments Apr 1, 2024
@BernieWhite BernieWhite added this to the v1.37.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pillar: reliability Aligned to the Reliability pillar. rule: api-management Rules for API Management
Projects
None yet
Development

No branches or pull requests

2 participants