Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm-ptn-subnet-nsg-routes #1693

Open
2 tasks done
Dylan-Prins opened this issue Nov 5, 2024 · 6 comments
Open
2 tasks done

[Module Proposal]: avm-ptn-subnet-nsg-routes #1693

Dylan-Prins opened this issue Nov 5, 2024 · 6 comments
Assignees
Labels
Language: Bicep 💪 This is related to the Bicep IaC language Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@Dylan-Prins
Copy link

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

ptn/network/subnet-nsg-routes

Module Details

I want to create a module that creates a subnet with routes and security rules. This helps when you make use of landing zone vending, which only deploys a virtual network. I saw that there was an issue already for Terraform, but not for Bicep.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

Dylan-Prins

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@Dylan-Prins Dylan-Prins added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Nov 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Nov 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Nov 5, 2024
@jtracey93
Copy link
Contributor

Hey @Dylan-Prins

Thanks for the proposal.

Can you expand a little further about what the module will do and add value over using resource modules to do this.

E.g. provide a baseline of NSG rules and UDRs ?

This'll help us make a decision on the module proposal 👍

@Dylan-Prins
Copy link
Author

Dylan-Prins commented Nov 8, 2024

Hi @jtracey93,

Actually I am looking for a template to use when i get a landingzone connected to a hub. The platform team is deploying the vnet with peering and i only want to deploy the subnets.

Now I use AVM for everything except deploying the subnets.

@jtracey93
Copy link
Contributor

jtracey93 commented Nov 11, 2024

Ah okay that makes sense @Dylan-Prins

We are currently working on how we enable child modules for resource modules. This scenario would be covered when we have child modules available.

E.g. we will be able to publish the subnet as child module of the virtual network resource. Which will allow you to just deploy subnets.

Would you agree this would solve your challenge?

@matebarabas matebarabas added the Status: In Triage 🔍 Picked up for triaging by an AVM core team member label Nov 11, 2024
@Dylan-Prins
Copy link
Author

@jtracey93 That would be a much better option! is there a ETA for the feature?

@jtracey93
Copy link
Contributor

We are discussing it each week, but no ETA just yet. But I don't think its a long way off. We are meeting later today, let me ask and then check-in there and report back here.

cc: @matebarabas @AlexanderSehr @eriqua @ReneHezser

@AlexanderSehr
Copy link
Contributor

+1 on @jtracey93's comment. If we publish a subnet pattern now, just to publish the corresponding resource module later, it may cause confusion - especially if they diverge.
That being said, if it turns out to take longer than hoped, then we can go ahead, and delist this module again later.

Regardless, I'd recommend to wait and for the time being rather use a plain resource implementation than publishing another module. Not my call though 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Bicep 💪 This is related to the Bicep IaC language Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Status: Proposed
Development

No branches or pull requests

4 participants