Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never crash when getting system layouts #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Never crash when getting system layouts #72

wants to merge 1 commit into from

Conversation

tari01
Copy link
Member

@tari01 tari01 commented Jul 18, 2024

fixes #66

@tari01 tari01 requested a review from sunweaver July 18, 2024 01:06
sunweaver
sunweaver requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@sunweaver sunweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we should use this PR to reduce code duplication when retrieving the system kbd layout (see my inline comment, move code to libayatana-common, for example, or move it into the non-dyndll-part of the keyboard indicator.

src/keyboard-x11.c Outdated Show resolved Hide resolved
@tari01 tari01 force-pushed the pr/system-layouts branch from c158862 to f4aba7e Compare August 26, 2024 16:05
@tari01 tari01 requested a review from sunweaver August 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunweaver sunweaver Awaiting requested review from sunweaver

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tari01 @sunweaver