Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide adaptive modes (theme, brightness/redshift) if geoclue-2.0 DBus service is not available #95

Open
sunweaver opened this issue Apr 23, 2024 · 7 comments

Comments

@sunweaver
Copy link
Member

If there is not geoclue-2.0 provider on the DBus session bus, hide the adaptive modes in display indicator.

@sunweaver sunweaver changed the title Hide adaptive modes (theme, brightness/redshift) if geoclue services is not available Hide adaptive modes (theme, brightness/redshift) if geoclue-2.0 DBus service is not available Apr 23, 2024
@tari01
Copy link
Member

tari01 commented Jun 24, 2024

I don't think we need to do this: the indicator has a fallback longitude/latitude which can be tweaked in GSettings.

@sunweaver
Copy link
Member Author

I don't think we need to do this: the indicator has a fallback longitude/latitude which can be tweaked in GSettings.

Please hide those menu items if they cannot be used. Note that the customer's target system is an enterprise desktop. Showing features that don't exist is no option there.

@tari01
Copy link
Member

tari01 commented Jun 24, 2024

I don't think we need to do this: the indicator has a fallback longitude/latitude which can be tweaked in GSettings.

Please hide those menu items if they cannot be used. Note that the customer's target system is an enterprise desktop. Showing features that don't exist is no option there.

But that's exactly my point: those features do exist and can be used even without geoclue.

@sunweaver
Copy link
Member Author

So, for clarification:

For the enterprise Linux, we want:

  • theme switching
  • manual adjustment of brightness and redness

The enterprise desktop won't have geoclue running and in that case, the following menu items should be invisible/hidden:

  • color temperature -> adaptive (cooler|(normal)|warmer)
  • theme profile -> adaptive

The adaptive seems to be alluding auto-leveling those well you by some information (time of day, timezone, location, time of year).

Are you saying that the auto-leveling works if we simply roll-out geo coordinates via GSettings?

@sunweaver
Copy link
Member Author

If so, we should be able to allow the user to adjust those geo-coordinates. (We must assume that they go travelling from time to time).

@sunweaver
Copy link
Member Author

However, this might be beyond the scope of a display indicator. In fact, we have white papers for a location indicator. There this would be a nice feature to land.

Not sure how to handle this for now, though.

@tari01
Copy link
Member

tari01 commented Jun 24, 2024

Are you saying that the auto-leveling works if we simply roll-out geo coordinates via GSettings?

Yes. I have written it so that it never crashes regardless of the geolocation state. It starts up with the last coordinates stored in GSettings (Greenwich by default) and updates them if geoclue becomes available. If geoclue times out, it stays as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants