Made OneTime bindings update on DataContext changes #17683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allows null as a valid value for bindings without path
MrJul
added
bug
customer-priority
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Dec 3, 2024
MrJul
added
the
backport-candidate-11.2.x
|
Added as a backport candidate due to the fix for |
grokys
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Alexizx00789999
approved these changes
Dec 15, 2024
Alexizx00789999
approved these changes
Dec 15, 2024
Alexizx00789999
approved these changes
Dec 15, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Add failing tests for OneTime and null data context bindings * Made OneTime bindings update on DataContext changes Also allows null as a valid value for bindings without path * Remove now obsolete test
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR changes how bindings with a
OneTimemode work, to behave the same way as in WPF (and as currently documented), updating their target not only a single time, but once per data context change.In addition,
nulldata contexts are now considered valid values for bindings without a path.What is the current behavior?
OneTimebindings are evaluated only once.Bindings without a path (
{Binding}) are considered "pending" (they don't update their target nor call their converter) while their data context isnull.What is the updated/expected behavior with this PR?
OneTimebindings are evaluated once per data context, like in WPF.nullis now a validDataContextfor pathless bindings, and will use the configuredTargetNullValueandConverter, also matching WPF.Notes
As explained in #17587 (comment), the two changes are entangled: with the previous behavior we can't have
nullbe a valid data context without breakingOneTimebindings using them.Unit tests have been added.
One unit test has been deleted, since one-time bindings now don't stop on the first update.
Fixed issues
IsVisiblebinding without a path is not applied #17587