Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG-Date control time jumps forward with DST #563

Open
arcanaxion opened this issue Aug 23, 2023 · 10 comments · May be fixed by #2364
Open

BUG-Date control time jumps forward with DST #563

arcanaxion opened this issue Aug 23, 2023 · 10 comments · May be fixed by #2364
Labels
Gui: Back-End 🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 💥Malfunction Addresses an identified problem. 🟨 Priority: Medium Not blocking but should be addressed

Comments

@arcanaxion
Copy link

arcanaxion commented Aug 23, 2023 •
edited
Loading

Description
The time portion of the date control behaves strangely when attempting to select a time after clocks shift with DST.

Specifically, when selecting a time after the clock moves forward (an hour) with DST, the control automatically modifies my selection by +1 hour.

How to reproduce

from taipy.gui import Gui, Markdown
import datetime as dt
from dateutil.tz import tzlocal, tzutc, gettz

tz_name = "Australia/Melbourne"

selected_datetime = dt.datetime(2023, 8, 11, tzinfo=gettz(tz_name)).astimezone(tzutc())

md = Markdown(
"""
## selected_datetime: 

<|{selected_datetime}|date|with_time|> <|{repr(selected_datetime)}|>
""")

Gui(md).run(time_zone=tz_name)

Then,

  1. Click on the date control
  2. Select a date and time after 1 October 2023 2:00 AM
    a. The taipy app time_zone is set to Melbourne, which turns their clock forward at 2023-10-01T02:00:00 to 2023-10-01T03:00:00
  3. Observe that clicking some hour would instead result in the selected hour being incremented by 1
    a. E.g. clicking the hour 04 would instead select 05
  4. Furthermore, changing the minutes would also increment the hour by 1

Also

Expected behavior
No automatic incrementing should happen and possibly also 0200 <= time < 0300 (which doesn't exist on 2023-10-01 in Melbourne) should not be selectable.

Screenshots
date-control-dst-issue

Runtime environment

  • OS: WSL
  • Chrome on Windows - Version 116.0.5845.97 (Official Build) (64-bit)
@arcanaxion arcanaxion added the 💥Malfunction Addresses an identified problem. label Aug 23, 2023
@jrobinAV jrobinAV transferred this issue from Avaiga/taipy-gui Nov 13, 2023
joaoandre-avaiga referenced this issue Nov 23, 2023
@trgiangdo
Merge pull request #682 from Avaiga/feature/#470-rename-configure-def…
07349d6 
…ault-methods

Refactor#470 - Rename configure_default_..() methods to set_default_..()
@dinhlongviolin1 dinhlongviolin1 transferred this issue from Avaiga/taipy Nov 28, 2023
@trgiangdo trgiangdo transferred this issue from Avaiga/taipy-gui Dec 5, 2023
@FlorianJacta FlorianJacta added the 🟨 Priority: Medium Not blocking but should be addressed label Dec 13, 2023
@FlorianJacta
Copy link
Member

A client reported this issue again. It seems tricky to handle.

@dinhlongviolin1 dinhlongviolin1 self-assigned this Mar 15, 2024
@jrobinAV jrobinAV added the 🔒 Staff only Can only be assigned to the Taipy R&D team label May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label May 22, 2024
@jrobinAV jrobinAV added 🆘 Help wanted Open to participation from the community and removed 🔒 Staff only Can only be assigned to the Taipy R&D team 🥶Waiting for contributor Issues or PRs waiting for a long time labels Jun 7, 2024
@jrobinAV jrobinAV added hacktoberfest hacktoberfest issues hacktoberfest - 200💎💎 Issues rewarded by 200 points labels Sep 25, 2024
@IvanLauLinTiong
Copy link

Hi @jrobinAV I would like to tackle this bug for hacktoberfest event . Could I be assigned to this issue? Thanks.

@FlorianJacta
Copy link
Member

Let me assign this to you @IvanLauLinTiong. If you need help, you can ask @FabienLelaquais. Thank you for your contribution

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 7, 2024
@quest-bot quest-bot
Copy link

quest-bot bot commented Oct 7, 2024

New Quest! image New Quest!

A new Quest has been launched in @Avaiga’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.

Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #563 to link your PR to this Quest.

Questions? Check out the docs.

@xyfer17
Copy link

xyfer17 commented Oct 8, 2024 •
edited
Loading

@arcanaxion @FlorianJacta could please assign the above issue to me, if @IvanLauLinTiong is not working on it.

@github-actions GitHub Actions
Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Oct 22, 2024
@CGaneshKumar2002
Copy link

CGaneshKumar2002 commented Oct 30, 2024 •
edited
Loading

Hey @arcanaxion, @FabienLelaquais, Is this issue happening only for this "Australia/Melbourne" location alone? Because when I tried from my end, the issue doesn't seem to happen for different timezones. I'd appreciate if you provide any inputs!

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 16, 2024
@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@jrobinAV jrobinAV removed hacktoberfest hacktoberfest issues hacktoberfest - 200💎💎 Issues rewarded by 200 points ⚔️ Quest Tracks quest-bot quests labels Dec 16, 2024
@dinhlongviolin1 dinhlongviolin1 linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gui: Back-End 🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 💥Malfunction Addresses an identified problem. 🟨 Priority: Medium Not blocking but should be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix dst time jump (#563) Avaiga/taipy
7 participants
@IvanLauLinTiong @dinhlongviolin1 @arcanaxion @xyfer17 @jrobinAV @FlorianJacta @CGaneshKumar2002