Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show stack trace in job selector when job fails #1251

Closed
4 tasks
MariahLeone opened this issue May 1, 2024 · 8 comments · Fixed by #1717
Closed
4 tasks

Show stack trace in job selector when job fails #1251

MariahLeone opened this issue May 1, 2024 · 8 comments · Fixed by #1717
Assignees
Labels
Core Related to Taipy Core 🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community ✨New feature 🟧 Priority: High Must be addressed as soon

Comments

@MariahLeone
Copy link

What would that feature address
When a job is failing, it is helpful to show the logs in the job selector to understand why the data is incorrect.

Description of the ideal solution
Display the job logs in a modal accessible from a job in the list

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%
  • Create related issue in taipy-doc for documentation and Release Notes
  • Check if a new demo could be provided based on this, or if legacy demos could be benefit from it
  • Ensure any change is well documented
@FlorianJacta
Copy link
Member

It will be really useful; you are correct! Would having a visual element called job be the solution for you, or should it be totally integrated within the job selector?

@FlorianJacta FlorianJacta added 🟧 Priority: High Must be addressed as soon Core Related to Taipy Core 🖰 GUI Related to GUI labels May 2, 2024
@jrobinAV jrobinAV added the 🆘 Help wanted Open to participation from the community label May 3, 2024
@MariahLeone
Copy link
Author

Integrated with the job selector is better, so all the job handling functionalities are supported with a single visual element. It is much easier to design a page when controls are integrated.

@yaten2302
Copy link
Contributor

Hi @FlorianJacta, if this issue is still needed, then I would like to work on this, could you please assign this to me.
Also, could you please give some information on how to reproduce this issue.

@MariahLeone
Copy link
Author

This is not an issue, but a new functionality asked.

When a job is failing, I would like to have a button in the job selector to display the job's logs and stacktrace.

@jrobinAV
Copy link
Member

jrobinAV commented Aug 27, 2024

Here is the proposal:

We want to add to the job selector a detail button for each job similarly to the following mockup:
image
This button should be controlled by a on_detail property deactivable or replacable by a gui callback.

By default clicking on a detail button should open a dialogue similar to the following mockup:
image

@jrobinAV
Copy link
Member

Note that we want to take the opportunity of this issue to improve the UX of the job selector control.

In particular we want to use the label as the man information in each column instead of the id. The id would be the second level information and could be displayed like an ellipse.

@FredLL-Avaiga FredLL-Avaiga self-assigned this Aug 27, 2024
@FredLL-Avaiga
Copy link
Member

FredLL-Avaiga commented Aug 28, 2024

added a property on_details

  • not set : adds a icon to the selector list that shows a dialog with details
  • set to False: hide the icon
  • set to a callback: calls the callback with the job id
    on_details_callback(state: State, id: str, payload: {'action': 'on_details_callback', 'args': ['JOB_scenario_task_e2e9329d-2d2c-45fd-b2e0-64921b88a666']})

FredLL-Avaiga pushed a commit that referenced this issue Aug 28, 2024
resolves #1251
@jrobinAV
Copy link
Member

Note that for now, only the stack trace is collected when the job fails. The logs are not collected. It may come later.

@FabienLelaquais FabienLelaquais changed the title Show logs and errors in job selector when job failing Show stack trace in job selector when job fails Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Taipy Core 🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community ✨New feature 🟧 Priority: High Must be addressed as soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants