Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOS: Add theme #7272

Merged
merged 5 commits into from
Aug 4, 2023
Merged

DOS: Add theme #7272

merged 5 commits into from
Aug 4, 2023

Conversation

madhusudhand
Copy link
Member

Changes proposed in this Pull Request:

Add new theme DOS, designed by @henriqueiamarino

image

@madhusudhand madhusudhand self-assigned this Jul 26, 2023
@madhusudhand
Copy link
Member Author

@henriqueiamarino Home template has an excerpt and also post content blocks, and the content appears to be redundant. Is this intentional?

image

@henriqueiamarino
Copy link
Collaborator

When I designed it, I considered blog posts to have an exclusive excerpt highlighting the text. But now it doesn't make much sense on a theme with no highlights, following vintage UIs aspect. Can you remove the excerpt, or do you want me to do it, @madhusudhand?

@henriqueiamarino
Copy link
Collaborator

In fact, I will conduct the changes and will let you know @madhusudhand thanks you.

@henriqueiamarino
Copy link
Collaborator

Hey @madhusudhand, DOS is updated — here and on the P2 as well.

dos.zip

@madhusudhand
Copy link
Member Author

Thanks for the updates @henriqueiamarino

I have only one comment on the text is a theme designed by Automattic. It doesn't go well with site title except for the demo site. Can you confirm?

image

Everything else looks good. Its a nice theme!

@henriqueiamarino
Copy link
Collaborator

henriqueiamarino commented Aug 3, 2023

Yes, thanks @madhusudhand this is a bit old; I didn't remember I added that line. It was removed anyway.

dos.zip

@madhusudhand
Copy link
Member Author

Thanks @henriqueiamarino for addressing the comments.

I have pushed them here and theme is now ready. 🚢

@madhusudhand madhusudhand merged commit 067bbb0 into trunk Aug 4, 2023
@madhusudhand madhusudhand deleted the add/dos branch August 4, 2023 07:27
@henriqueiamarino
Copy link
Collaborator

Hey @madhusudhand, here are the issues I found while building DOS demo site:

  • Headings still have Rubik as a standard font. Rubik is not present on the theme; I used JetBrains Mono only. I fixed it.
  • Post-meta is missing from the demo site. It shows a template part error there. To fix it, I detached the Pattern and added the group again — it might need another fix from your side. I am not sure.
  • The mobile view is breaking by a separator I added after the post-meta, inside the post-template. I fixed it by allowing the row to wrap to multiple lines. Should I edit the theme and upload it again?

@madhusudhand
Copy link
Member Author

Can you zip and upload the theme from Automattic/themes trunk branch in demo site and do these changes, so that it would be easier merge those chases.

Attach the zip after final changes here. I will bring them in.

@henriqueiamarino
Copy link
Collaborator

I fixed it on my demo site, exported it, and updated the P2 with this file.

I am sorry for all the changes. I didn't know how to adjust many settings properly when I designed this theme — mainly related to the mobile view. This is the final update, anyway. Please, let me know when this is ready so I can launch it. Thanks @madhusudhand.

dos.zip

@madhusudhand
Copy link
Member Author

@henriqueiamarino Provided fixes are merged and deployed here #7301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants