-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOS: Add theme #7272
DOS: Add theme #7272
Conversation
@henriqueiamarino Home template has an excerpt and also post content blocks, and the content appears to be redundant. Is this intentional? |
When I designed it, I considered blog posts to have an exclusive excerpt highlighting the text. But now it doesn't make much sense on a theme with no highlights, following vintage UIs aspect. Can you remove the excerpt, or do you want me to do it, @madhusudhand? |
In fact, I will conduct the changes and will let you know @madhusudhand thanks you. |
Hey @madhusudhand, DOS is updated — here and on the P2 as well. |
Thanks for the updates @henriqueiamarino I have only one comment on the text Everything else looks good. Its a nice theme! |
Yes, thanks @madhusudhand this is a bit old; I didn't remember I added that line. It was removed anyway. |
Thanks @henriqueiamarino for addressing the comments. I have pushed them here and theme is now ready. 🚢 |
Hey @madhusudhand, here are the issues I found while building DOS demo site:
|
Can you zip and upload the theme from Automattic/themes Attach the zip after final changes here. I will bring them in. |
I fixed it on my demo site, exported it, and updated the P2 with this file. I am sorry for all the changes. I didn't know how to adjust many settings properly when I designed this theme — mainly related to the mobile view. This is the final update, anyway. Please, let me know when this is ready so I can launch it. Thanks @madhusudhand. |
@henriqueiamarino Provided fixes are merged and deployed here #7301 |
Changes proposed in this Pull Request:
Add new theme DOS, designed by @henriqueiamarino