Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add filter criterion for subscription state #438

Open
aidano opened this issue Oct 24, 2022 · 3 comments · May be fixed by #450
Open

Enhancement: Add filter criterion for subscription state #438

aidano opened this issue Oct 24, 2022 · 3 comments · May be fixed by #450

Comments

@aidano
Copy link

aidano commented Oct 24, 2022

I'd like to show, for example, any Downloaded, In Progress episodes irrespective of subscription state.

Proposal: Create a new filter that allows for podcast subscription state to be defined ( All | Subscribed | Not Subscribed)

Since current behavior is that a filter automatically includes only episodes of subscribed podcasts, perhaps the above criterion can default to Subscribed when presented in the UI so that existing filters remain backwards compatible, and are updated only if the user changes the value to include All or Not Subscribed.

@aidano
Copy link
Author

aidano commented Oct 25, 2022

I've taken a look through the code and this seems doable by an external contributor like myself, so I plan to have a PR for review available soon.

Summary of the changes:

  1. Update the UI to contain a new 'Subscription State' filter chip, which pops up a screen with radio buttons for 'All', 'Subscribed', and 'Not Subscribed' –– similar to the Download Status filter UX.
  2. Add new columns to the SJFilteredPlaylist table for subscription states subscribed and notSubscribed, of type integer, and defaulting to 1 for subscribed in order to retain the existing behavior for filters (only show Subscribed).
  3. Add the logic for persistence and querying to connect the dots between 1) and 2)

@jtbrough
Copy link

jtbrough commented Jun 7, 2023

I came here to suggest this same feature. I am honestly surprised an app this rich in filter capability has made it this long without it. I view podcasts in two distinct modes:

  1. subscribed podcasts
  2. those I dabble with, either because I know I won't listen to most episodes or because it's new to me and I'm trying it out

Being able to have filters for downloaded and in progress regardless of the subscription state would be very helpful. As it is now, these partially played unsubscribed podcasts can only really be "managed" in the up next area, which goes sideways if you play any episode that isn't in the up next flow.

I would also welcome the ability to bookmark a podcast even when not subscribed, but that's a feature request for another day... :)

@austinmcconnell
Copy link

I would love for this change to be implemented. I view podcasts in the same modes you do and I think the current behavior is pretty non-intuitive for mode 2. I have looked for alternative podcasts apps a few times specifically because non-subscribed downloaded episodes are so buried in Pocket Casts.

Personally, I would love for those non-subscribed downloaded episodes to show up on the main screen with podcast art and everything, but I suspect that would be a more controversial change. Having the episodes show up in the filters tab would be a great step forward in usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants