Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that the first column after the checkbox in the table view displays row actions #51

Open
rinatkhaziev opened this issue Oct 18, 2012 · 2 comments
Open

Make sure that the first column after the checkbox in the table view displays row actions #51

rinatkhaziev opened this issue Oct 18, 2012 · 2 comments

Comments

@rinatkhaziev
Copy link
Contributor

If provider class doesn't have columns_{$custom_column} method, there will be no row actions presented. It would be nice to figure out default logic for the first column to display dem actions.
@rinatkhaziev
Copy link
Contributor Author

@danielbachhuber @jeremyfelt just discovered this.

@ghost ghost assigned jeremyfelt Oct 19, 2012
@jeremyfelt
Copy link
Contributor

I'll take a stab at this soon.

jeremyfelt added a commit that referenced this issue Mar 6, 2013
@jeremyfelt
Track row actions output on each row to catch cases where custom outp…
2d8c545 
…ut may not be added

When a provider class does not provide a method to output one of its registered columns, our list table should account for the possible lack of row actions.

This commit adds a tracking property for the display of row actions. If a column's output is not handled by the provider class and row actions have not yet been displayed, we handle output of the row actions. Once row actions have been output once, the flag is maintained throughout the row. When the row is complete, the flag is reset for the next.

One quirk - if a provider class handles the output for the first column, but does not handle row actions, and does not handle the output for the next column, row actions will be output in that second column. This feels a little weird, but I think gets us close enough.

Fixes #51
@jeremyfelt jeremyfelt mentioned this issue Mar 6, 2013
Closed
@jeremyfelt jeremyfelt removed their assignment Jul 9, 2019
@GaryJones GaryJones modified the milestones: 0.5.0, Future Release Mar 14, 2022
@GaryJones GaryJones removed this from the Future Release milestone Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@GaryJones @jeremyfelt @rinatkhaziev