Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate sniffs being removed in VIPCS 3.0 #752

Closed
GaryJones opened this issue Mar 7, 2023 · 2 comments
Closed

Deprecate sniffs being removed in VIPCS 3.0 #752

GaryJones opened this issue Mar 7, 2023 · 2 comments

Comments

@GaryJones
Copy link
Contributor

What problem would the enhancement address for VIP?

To provide a friendlier developer experience, we can formally deprecate the sniffs in 2.x that we know will be removed in 3.x.

See:

Describe the solution you'd like

Action plan suggestion:

  • Deprecate the sniff in the next release (2.x) by:
    • Adding a deprecation warning to the sniff which will inform people to remove the sniff reference from their own custom ruleset.
    • Silencing all messages from the sniff from within the VIPMinimum ruleset, effectively removing the sniff already for people using the standard rulesets.
  • Remove the actual sniff in the next major, i.e. 3.0.0.
@GaryJones GaryJones added this to the 2.4.0 milestone Mar 7, 2023
@jrfnl
Copy link
Collaborator

jrfnl commented Aug 21, 2023

Maybe just add a note in the changelog (soft deprecation) of 2.3.4 ?

@GaryJones GaryJones modified the milestones: 2.4.0, 2.3.4 Aug 21, 2023
@jrfnl
Copy link
Collaborator

jrfnl commented Aug 24, 2023

Closing as fixed via soft deprecation in the 2.3.4 release.

(issue didn't close automatically as the branch was merged to master, not develop)

@jrfnl jrfnl closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants