Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for upcoming change in WP 5.7 / script tag use #591

Open
jrfnl opened this issue Oct 23, 2020 · 1 comment
Open

Account for upcoming change in WP 5.7 / script tag use #591

jrfnl opened this issue Oct 23, 2020 · 1 comment

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Oct 23, 2020

PR WordPress/WordPress-Coding-Standards#1956 in WPCS refers to changes in WP Core which will remove the use of the <script> HTML tag in PHP code.

Any existing sniff which looks at the content of inline HTML and takes the <script> tag into account will need to be reviewed to see if it can still detect what it is looking for with the "new" way of writing this type of code.

This PR to WP Core gives some good examples of the "new" way of writing this type of code and can be used to for code samples: https://github.com/WordPress/wordpress-develop/pull/498/files

This PR shows the new functionality which will be added to Core: WordPress/wordpress-develop#591

@rebeccahum
Copy link
Contributor

Related sniff in progress: #623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants