Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BatCache related sniff #492

Closed
GaryJones opened this issue Jul 6, 2020 · 4 comments
Closed

Remove BatCache related sniff #492

GaryJones opened this issue Jul 6, 2020 · 4 comments
Assignees
@rebeccahum
Labels
Type: Enhancement

Comments

@GaryJones
Copy link
Contributor

GaryJones commented Jul 6, 2020 •
edited
Loading

What problem would the enhancement address for VIP?

Words matter, and the current understanding is that whitelist has negative connotations for some people that can be easily avoided by using a different term.

BatCache is not used on the current VIP platform, so this sniff is no longer needed.

Describe the solution you'd like

Change class, class properties and any other references to whitelist for something else.

Remove the sniff.

Additional context

Apart from the changelog, the only other references seem to be in relation to the BatcacheWhitelistedParams sniff and related test files.
@GaryJones GaryJones added this to the 2.2.0 milestone Jul 6, 2020
@rebeccahum
Copy link
Contributor

+1000000

@rebeccahum rebeccahum self-assigned this Jul 6, 2020
@GaryJones GaryJones modified the milestones: 2.2.0, 3.0 Jul 27, 2020
@GaryJones
Copy link
Contributor Author

This is important, but changing the class name will create a backwards compatibility break, so that means it needs to be done on a major release.

It's possible that all of the VIP clients will have moved over from WordPress.com VIP to VIP Go platform by the time the VIPCS is released, which means that this issue can change to removing this sniff completely, since it's only used in the WordPress-VIP-Minimum ruleset.

@jrfnl jrfnl mentioned this issue Oct 23, 2020
Merged
@GaryJones
Copy link
Contributor Author

It's possible that all of the VIP clients will have moved over from WordPress.com VIP to VIP Go platform by the time the VIPCS is released, which means that this issue can change to removing this sniff completely, since it's only used in the WordPress-VIP-Minimum ruleset.

This is now correct, so the BatCache-related sniff can be removed completely now.

@GaryJones GaryJones changed the title Change name of BatcacheWhitelistedParams sniff Remove BatCache related sniff Mar 7, 2023
@GaryJones
Copy link
Contributor Author

Closing in favour of #613.

@GaryJones GaryJones closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2023
@GaryJones GaryJones removed this from the 3.x milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebeccahum rebeccahum

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GaryJones @rebeccahum