Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib version 3.8 results in test failure #188

Open
ldXiao opened this issue Sep 24, 2023 · 0 comments
Open

matplotlib version 3.8 results in test failure #188

ldXiao opened this issue Sep 24, 2023 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@ldXiao
Copy link

ldXiao commented Sep 24, 2023

Describe the bug
Using matplotlib 3.8 results in runtime error in calculations.py

To Reproduce
Steps to reproduce the behavior:

  1. uninstall matplotlib old version and install matplotlib stable version
  2. run make tests

error message

=================== short test summary info ==================== 
FAILED aat/tests/strategy/test_offline_calculations.py::TestOfflineCalculations::test_calculations - AttributeError: 'GrouperView' object has no attribute 'join'

with some simple debug, we can trace to line 335 of aat/tests/strategy/test_offline_calculations.py:

...python
        # join all but last on x axis
        for ax in axes[:-1]:
            axes[0].get_shared_x_axes().join(axes[0], ax)
...

where newer version of matplotlib has modified the method get_shared_x_axes() to return cbook.GrouperView object which does not have an attribute join

We can either restrict the maximum version number of matplotlib or modify aat code to make it compatible

@timkpaine timkpaine added the dependencies Pull requests that update a dependency file label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants