-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fn_jerryCanRefuel - Cancel action you get a full canister #685
Comments
CONFIRMED! Also: Already found the issue: fn_jerryRefuel
fn_jerryCanRefuel
By setting life_action_inUse and life_interrupted to false directly within the exitWith the check after the loop fails:
The if-condition is not met and hence it goes straight to call fn_handleInv and hence giving you full fuel canister even if action is cancled. Solution: Simple copy'n'paste of the fn_jerrRefuel: Remove life_action_inUse and life_interrupted set to false within the exitWith to correctly trigger the if() condition. |
fixed with merge of #686 - can be closed (I guess?) |
|
Will need to duplicate this commit onto v5.X.X, then can close :) |
|
File: fn_jerryCanRefuel
If you cancel the action while filling the canister, you will still get a full canister back.
The text was updated successfully, but these errors were encountered: