You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
Should we consider inverting the weekly boss counter? Currently the app displays remaining discounts (0/3 = completed), but it might make more sense to show completed discounts instead (3/3 = completed) to be consistent with the daily quest counter (4/4 being completed).
For reference, Paimon tray apps on other platforms display the two counters consistently:
The idea of consistency: accepted. Completed rather than remaining: rejected.
At the very dawn of PaimonTray, it was developed just to taste WinUI 3, and I used to reckon that it would last no longer than 3 months. That's why I code in a casual style and follow the 米游社/HoYoLAB UI patterns for the real-time notes introducing inconsistency. I would like to let you know that making the real-time note data show in a consistent way has already been considered a TODO task as a part of refactoring UI display modes after some other necessary work. The planned consistent way is "remaining rather than completed" for not only daily commissions and weekly bosses but also others.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Should we consider inverting the weekly boss counter? Currently the app displays remaining discounts (0/3 = completed), but it might make more sense to show completed discounts instead (3/3 = completed) to be consistent with the daily quest counter (4/4 being completed).
For reference, Paimon tray apps on other platforms display the two counters consistently:
Happy to send a PR if this sounds reasonable.
The text was updated successfully, but these errors were encountered: