Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mod-compability with Zeus waypoint definitions #491

Open
kerckasha opened this issue Jun 15, 2019 · 4 comments
Open

Improve mod-compability with Zeus waypoint definitions #491

kerckasha opened this issue Jun 15, 2019 · 4 comments
Labels
change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Milestone

Comments

@kerckasha
Copy link

kerckasha commented Jun 15, 2019

Arma 3 Version: 1.92 (stable)
CBA Version: 3.11.2 (stable)
Achilles Version: 1.2.1 (stable)

Mods:

- CBA_A3
- Achilles

Description:
BI shortsightedly hard coded the waypoint definitions for Zeus in the RscAttributeWaypointType dialog, and Achilles currently overrides this dialog to add extra waypoints. This is fine until another mod wants to add their own waypoints and a conflict occurs but I have found a solution.

+= was added to config based arrays awhile back and does work in the Zeus waypoint dialog but is reliant on other addons using it for it to continue working, so while in my test addon += works with just Vanilla A3, if I run achilles alongside it Achilles overrides it, unless I set Achilles in my required addon.

Here's an example of how i set it up for Iron Front

names[] += {"configFile >> 'cfgWaypoints' >> 'LIB' >> 'LIB_AmphibiousAssault'","configFile >> 'cfgWaypoints' >> 'LIB' >> 'LIB_StaticLine'"};
strings[] += {"$STR_LIB_DN_AMPHIBIOUS_ASSAULT","$STR_LIB_DN_WP_StaticLine"};
@kerckasha
Copy link
Author

kerckasha commented Jun 15, 2019

image
Here's an ingame example after I made a quick change to Achilles (obviously the two 'land' arent desired, or some of them missing (that's just my bad removing stuff that I thought already existed))

@CreepPork CreepPork added change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. labels Jun 15, 2019
@CreepPork CreepPork added this to the Backlog milestone Jun 15, 2019
@CreepPork
Copy link
Member

I'm trying to look the config up in GitHub and I can't find it because of our terrible mod structure.
As you have made some changes already to Achilles, can you create a PR? That'll be great.

@kerckasha
Copy link
Author

I can but there's one issue, achilles replaces some of the default ones (Land) and I'm unsure how to handle that as += can only add to existing arrays, not change values.

\addons\ui_f\dialogs\Replacement\RscDisplayWaypointAttributes.hpp is the file in question

@CreepPork
Copy link
Member

Thanks for the file.
Yeah, I dunno about that one either. My only guess is you could create a separate PBO for compatibility and override Achilles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Projects
None yet
Development

No branches or pull requests

2 participants