Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering AEKeys into matter condenser #7787

Open
ramidzkh opened this issue Mar 23, 2024 · 7 comments
Open

Allow filtering AEKeys into matter condenser #7787

ramidzkh opened this issue Mar 23, 2024 · 7 comments

Comments

@ramidzkh
Copy link
Contributor

Matter condenser accepts radioactive gasses with no API to not do that

@shartte
Copy link
Member

shartte commented Mar 25, 2024

Do other trash cans have such support?

@Technici4n
Copy link
Member

I don't think there really exist gas trash cans? 🤔

@shartte
Copy link
Member

shartte commented Mar 25, 2024

@Technici4n Well, what about fluid or other trash cans? How do they handle it?
We have the slight problem of not being able to define tags on AEKeys I think

@Random832
Copy link
Contributor

In general Mekanism and its radioactive stuff is unique in attempting to prevent you from destroying a resource without consequences, there's probably not much precedent elsewhere.

@shartte
Copy link
Member

shartte commented Mar 25, 2024

In general Mekanism and its radioactive stuff is unique in attempting to prevent you from destroying a resource without consequences, there's probably not much precedent elsewhere.

Yes but I am not willing to introduce an entire java-based code path just for this one AEKey...
Filtering an entire AEKeyType is a different story (since those can be included in vanilla tags), but I'd assume you still want chemical->condenser to work in general.

@Technici4n
Copy link
Member

Well you can store any fluid in any tank. But you can't store radioactive gasses in regular chemical tanks. I think the feature request makes sense.

We could just post an event for matter condenser input or something like that, idk.

@XenonDB
Copy link

XenonDB commented May 1, 2024

I think an alternative way is make an API to allow filter of storage bus able to be post-modified in some circumstances.
For example, applied mekanistics can add a hidden nuclear waste blacklist filter for all storage bus which attach to Matter condenser.

Also, in the future, if TC7 is released and thaumic energestic update for supporting TC7 and AE2, it might need such feature since TC must not allow anyone to handle essentia without completing researching.
For example, insert essentia card into storage bus to remove this limitation.

Maybe some mod can also add upgrade such like custom tag filter card or create filter card(allow filter option based on create filter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants