Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 16 actions are deprecated #57

Closed
pllim opened this issue Oct 25, 2023 · 4 comments · May be fixed by #58
Closed

Node.js 16 actions are deprecated #57

pllim opened this issue Oct 25, 2023 · 4 comments · May be fixed by #58

Comments

@pllim
Copy link

pllim commented Oct 25, 2023

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: apple-actions/import-codesign-certs@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

import-codesign-certs/action.yml

Line 31 in 5565bb6

using: 'node16'

@jozefizso jozefizso mentioned this issue Nov 16, 2023
Open
@grzegorzkrukowski
Copy link

GitHub announced that they will enforce node20 instead of a warning on 13th May

@paulmcgrathparamount
Copy link

There's a PR awaiting merging for this issue - #58 - but in the meantime one workaround I found was to check the logs of the git workflow where this action is called and copying the security commands output by the script. Then I just replace the invocation of this action with running those commands directly. Probably not an ideal solution but it does get rid of the deprecation warning.

@koppor koppor mentioned this issue May 2, 2024
Merged
6 tasks
@ssrobins
Copy link
Contributor

Upgraded with #64

pllim added a commit to pllim/jdaviz that referenced this issue May 10, 2024
@pllim
BLD: Upgrade import-codesign-certs to v3
4f3e7a7 
It was just released to address Apple-Actions/import-codesign-certs#57
@pllim pllim mentioned this issue May 10, 2024
Merged
9 tasks
@pllim
Copy link
Author

pllim commented May 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade action to NodeJS v20 slidoapp/import-codesign-certs
4 participants
@grzegorzkrukowski @pllim @ssrobins @paulmcgrathparamount