Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests with DataProvider are failing #317

Open
SrinivasanTarget opened this issue Apr 29, 2018 · 11 comments
Open

Tests with DataProvider are failing #317

SrinivasanTarget opened this issue Apr 29, 2018 · 11 comments
Assignees
@SrinivasanTarget
Labels
bug

Comments

@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Apr 29, 2018 •
edited

if i have only data provider, then test passes in distribute mode
if i have both dp and normal, test is failing in distribute mode
if i have only data provider, then test fails in parallel mode
if i have both dp and normal, test fails in parallel mode
@SrinivasanTarget
Copy link
Member Author

@saikrishna321 looks like things are screwed up :)

@SrinivasanTarget SrinivasanTarget self-assigned this Apr 30, 2018
@SrinivasanTarget SrinivasanTarget changed the title Tests with DataProvider on parallel mode is failing Tests with DataProvider are failing Apr 30, 2018
@saikrishna321
Copy link
Member

if i have both dp and normal, test is failing in distribute mode

you mean normal test in distribute fails ?

@SrinivasanTarget
Copy link
Member Author

not normal in distribute mode... it fails only if you have above combinations

@SrinivasanTarget
Copy link
Member Author

might be a testNG issue too

@shridharkalagi
Copy link
Contributor

this happens only when @DataProvider(parallel = true) and data-provider-thread-count is greater than one in testng.xml I have created an Issue here with more details.

@saikrishna321
Copy link
Member

@SrinivasanTarget @shridharkalagi from testNg issue comments, its a bug at our end we had to handle the device pool correctly

@shridharkalagi
Copy link
Contributor

yes. For now, easy workaround would be to remove parallel=true for the dataprovider

@saikrishna321
Copy link
Member

@shridharkalagi but does not solve the problem 🙅‍♂️

@SrinivasanTarget
Copy link
Member Author

9542bf5

@saikrishna321
Copy link
Member

@SrinivasanTarget has this been tested ? if yes, can the branch get merged ?

@SrinivasanTarget
Copy link
Member Author

Not yet..will keep you posted

SrinivasanTarget pushed a commit that referenced this issue May 24, 2018
@saikrishna321 @SrinivasanTarget
fix for #317 (#325)
970452e 
* handle chromedriver port gracefully
Co-authored-by:shridharkalagi <[email protected]>

* remove default log level from appium service

* dataprovider fix by handling threads

* update caps for toc specific et2 smoke

* Fixing issue #322 (#324)

* Adding devices based the caps

* Added check for real device caps as well

* Update condition to work only for mac
shridharkalagi pushed a commit to shridharkalagi/AppiumTestDistribution that referenced this issue May 25, 2018
@saikrishna321 @shridharkalagi
fix for AppiumTestDistribution#317 (AppiumTestDistribution#325)
f21cb6d 
* handle chromedriver port gracefully
Co-authored-by:shridharkalagi <[email protected]>

* remove default log level from appium service

* dataprovider fix by handling threads

* update caps for toc specific et2 smoke

* Fixing issue AppiumTestDistribution#322 (AppiumTestDistribution#324)

* Adding devices based the caps

* Added check for real device caps as well

* Update condition to work only for mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SrinivasanTarget SrinivasanTarget

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@saikrishna321 @SrinivasanTarget @shridharkalagi