-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement -u #10
Comments
Passing in the URL to the zsync file directly works though (and is even more elegant):
The original
|
You're right though, |
As a workaround, it may be sufficient to give an error message when the user tries to use |
May be sufficient, but there's cases in which the |
I mean, having a local |
Not relevant, yes, but possible, and supported by |
I think you are underestimating this feature. This feature can make zsync2 widely used. This allows zsync file repositories to be separated from the original links. And zsync file repositories are small and easy to store, and easy to be integrated with package managers from linux distributions. And the only feature that zsync2 lacks for that, is the possibility to easily change the url (mirror) that will be used together with the zsync file. |
@ferion11 could you make a pull request? |
I will take a look at the code. But I have to make GentooLinux ebuilds for "zsync2", "lib/cpr" and "lib/args" first. |
Gentoo ebuild (online on danrepo) and the implementation of "-u" done. I tested it with github links and work well. But I found one bug using the kernel.org links: |
Thanks for sending the PR @ferion11, I've commented there. |
@probonopd , It looks like the @TheAssassin hasn't been active on github for some time. |
@ferion11 thanks for your PR. Going to review now. The best way to get in touch is usually via IRC in #appimage on Freenode by the way. Or just write me a mail next time. |
@TheAssassin Glad to see you back. Thanks for the extra contact way too :) |
As zsync2 is meant to be a drop-in replacement for
zsync
, it should support-u
:Use case (from AppImage/AppImageKit#519 (comment)):
Test case:
The text was updated successfully, but these errors were encountered: