fix: error format of TextEditingDeltaInsertion #1004
+108
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
=======================================
Coverage 72.16% 72.17%
=======================================
Files 319 319
Lines 15246 15248 +2
=======================================
+ Hits 11003 11005 +2
Misses 4243 4243 ☔ View full report in Codecov by Sentry. |
LucasXu0
reviewed
Dec 27, 2024
Comment on lines
324
to
327
| selection: | ||
| oldText.startsWith(_whitespace) ? selection << _len : selection, | ||
| composing: | ||
| oldText.startsWith(_whitespace) ? composing << _len : composing, |
There was a problem hiding this comment.
Please add a test:
- insert a space into an empty line.
- delete the space.
- verify that the result is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix AppFlowy-IO/AppFlowy#7049
Before the fix:
2024-12-26.161528.mp4
After the fix:
2024-12-26.161415.mp4