Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR FEATURE]: Reimplement ProviderSupport #9

Open
1 task done
Supereg opened this issue Dec 27, 2021 · 0 comments
Open
1 task done

[MINOR FEATURE]: Reimplement ProviderSupport #9

Supereg opened this issue Dec 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Supereg
Copy link
Member

Supereg commented Dec 27, 2021

Problem

The original release (v0.1.x) of ApodiniMigrator included support for migration guide providers to annotate addition, removal and idChange (identifier renames) with so called ProviderSupport objects. Those could be used to resolve uncaught type renames or wrongly classified type renames.

With the rewrite happening in v0.2.0, the feature wasn't reimplemented, as of now. This issue tracks reimplementing this feature.

Solution

As the newly introduced change model enforces the structure of a specific change, one can reimplement this feature with distinct typed versions for addition, removal and idChange cases of the Change enum. Therefore, this can be implemented for any change element.

Additionally, one need to implement a resolving step (ideally in the DocumentComparator) which actually interprets the provided renaming hints, such that a Migrator won't need to manually do that.

Additional context

#6

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@Supereg Supereg added the enhancement New feature or request label Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant