We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we do not detect error used with empty/zero, right now
var err error assert.Empty(t, err) assert.Zero(t, err)
We should recommend using NoError
NoError
var err error assert.NoError(t, err)
this pattern is widely used https://github.com/search?q=language%3Ago+%22assert.Empty%28t%2C+err%22&type=code https://github.com/search?q=language%3Ago+%22assert.Zero%28t%2C+err%29%22&type=code
These two are candidates for error-nil
error-nil
Originally posted by @ccoVeille in #119 (comment)
The text was updated successfully, but these errors were encountered:
Please confirm if the logic is valid for you, then I can code it
Sorry, something went wrong.
Yes, this is valid for me.
Need to add to ignored cases in tests:
assert.Empty(t, errs) assert.Empty(t, err.String())
No branches or pull requests
we do not detect error used with empty/zero, right now
We should recommend using
NoError
this pattern is widely used https://github.com/search?q=language%3Ago+%22assert.Empty%28t%2C+err%22&type=code
https://github.com/search?q=language%3Ago+%22assert.Zero%28t%2C+err%29%22&type=code
These two are candidates for
error-nil
Originally posted by @ccoVeille in #119 (comment)
The text was updated successfully, but these errors were encountered: