formatter -fix removes fmt.Sprintf but doesn't suffix assertion method with f

[mmorel-35]

With master version of testifylint, with (Example from https://github.com/kubernetes/kubernetes/pull/127649/files)

assert.Error(t, err, fmt.Sprintf("Profile %s should not be valid", test.profile))

The suggestion is

assert.Error(t, err, "Profile %s should not be valid", test.profile)

But I expect

assert.Errorf(t, err, "Profile %s should not be valid", test.profile)

[Antonboom]

@mmorel-35 hi!

did you use --formatter.require-f-funcs flag?

(disabled by default to avoid a lot of changes in large codebases, read the checker docs)

[mmorel-35]

With --formatter.require-f-funcs it adds the f even if there are no argument to the message:

While with :

assert.Error(t, err, "Profile should not be valid")

I don't expect to have

assert.Errorf(t, err, "Profile should not be valid")

but with:

assert.Error(t, err, "Profile %s should not be valid", test.profile)

I expect

assert.Errorf(t, err, "Profile %s should not be valid", test.profile)

[Antonboom]

Your expectations are invalid.
Please, read the checker doc carefully, including historical reference.

By Go convention f-suffix is triggered by any message, without arguments too.
Look at fmt.Sprint and fmt.Sprintf signatures for example.