Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit files #1185

Closed
fabiandecuveland opened this issue Jul 9, 2024 · 8 comments · Fixed by #1198
Closed

Can't edit files #1185

fabiandecuveland opened this issue Jul 9, 2024 · 8 comments · Fixed by #1198
Assignees
Labels
bug Something isn't working triage Interesting but stale issue. Will be close if inactive for 3 more days after label added.

Comments

@fabiandecuveland
Copy link

Policy and info

  • Maintainers will close issues that have been stale for 14 days if they contain relevant answers.
  • Adding the label "sweep" will automatically turn the issue into a coded pull request. Works best for mechanical tasks. More info/syntax at: https://docs.sweep.dev/

Expected Behavior

I'm trying to have gpt-engineer change a list of files.

Current Behavior

I ran gpt-engineer <project_dir> -i.
After manually editing the generated list of files in file_selection.toml to include all 7 files in the folder, I run the command again. The files are being read and changes proposed, but instead of writing the changes to the files, the following error appears after the LLM response:

WARNING:root:multiple candidates for starting index
WARNING:root:multiple candidates for starting index
WARNING:root:multiple candidates for starting index
Error while improving the project: 'dashboard/index.js'

The files have not been changed.

Failure Information

macOS 14.5
iTerm
Python 3.12

Failure Logs

debug_log_file.txt

@fabiandecuveland fabiandecuveland added bug Something isn't working triage Interesting but stale issue. Will be close if inactive for 3 more days after label added. labels Jul 9, 2024
@captivus
Copy link
Collaborator

@similato87 can you please have a look at this?

@similato87
Copy link
Collaborator

similato87 commented Jul 18, 2024

@fabiandecuveland, thank you for providing the details necessary to enhance our project!

I reviewed the log file, which indicated an error occurred when our project attempted to write diffs back to your codebase.

Could you confirm the process you undertook? You selected three files—comments-paper/index.js, charts-paper/index.js, stories-paper/index.js—for improvements. Our project then successfully generated diffs for each. Does this accurately reflect your experience?

Additionally, dashboard/index.js was supposed to be treated as a new file and written back to your codebase. However, it either wasn't detected as a new file or it was just generated for no reason. Which scenario do you think is more accurate for your situation?

@viborc
Copy link
Collaborator

viborc commented Jul 25, 2024

Hey @fabiandecuveland, can you please look at @similato87's comment and answer so we can try to solve this issue?

@viborc
Copy link
Collaborator

viborc commented Aug 1, 2024

Hey @fabiandecuveland can you please check this? If we don't hear back from you by next Thursday we'll be closing this issue, but you are always welcome to open it.

@fabiandecuveland
Copy link
Author

@similato87 Thanks for the reply and sorry for taking so long to answer.
I selected 7 files by uncommenting their path in file_selection.toml, but according to the log only 3 were uploaded.
In a first step of adapting ESM export statements, diffs were created for these 3 files.
In a second step of adapting ESM import statements in dashboard/index.js a diff was created for that file as well.
Unfortunately, no files were written to.

@similato87
Copy link
Collaborator

@fabiandecuveland Thanks for the reply and no worries about the delay!

Good news! PR #1198 will fix this issue. We will let you know when the PR is merged.

@similato87 similato87 linked a pull request Aug 6, 2024 that will close this issue
@fabiandecuveland
Copy link
Author

@similato87 Good to hear! For when is the release scheduled?

@similato87
Copy link
Collaborator

@fabiandecuveland It was merged last week. If you pull the latest main you can see the updates. For the Pypi release, we will probably have a new release in a month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Interesting but stale issue. Will be close if inactive for 3 more days after label added.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants