Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: To add a flexible way to specify more than 1 key combination (KeySet) #5

Open
Animeshz opened this issue Dec 30, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Animeshz
Copy link
Owner

Animeshz commented Dec 30, 2020

Current implementation only allows to specify one KeySet when calling some function in the Keyboard.

But that's not really idiomatic, in sense that we may want to do something like (Key.LeftCtrl or Key.RightCtrl) + K combination, in this case we can add two different handler for that (or create a lambda in a variable and call the function twice), but in some parts like suspensive waiting for key combination(s) to be pressed it is quite cumbersome.

Similarly if we want something like (Key.LeftCtrl or Key.RightCtrl) + (Key.LeftShift or Key.RightShift) + G the code becomes multiplicative large (i.e. setting the handler 4 times).

So the issue is clear, to implement a flexible way to pass a generic KeyCombination which is different from KeySet and allows to interact with the high-level api in even more convenient way!

@Animeshz Animeshz added enhancement New feature or request good first issue Good for newcomers labels Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant